This repository was archived by the owner on Dec 2, 2020. It is now read-only.
event subtyping#86
Open
edmund-huber wants to merge 1 commit intosquare:masterfrom
edmund-huber:event_subtyping
Open
event subtyping#86edmund-huber wants to merge 1 commit intosquare:masterfrom edmund-huber:event_subtyping
edmund-huber wants to merge 1 commit intosquare:masterfrom
edmund-huber:event_subtyping
Conversation
lib/cube/event.js
Outdated
Collaborator
There was a problem hiding this comment.
This change seems unrelated. Also, you've effectively changed it to /^[a-zA-Z0-9_]+$/, which means that event types can start with a number (which is bad).
Collaborator
|
Related #59 |
Closed
Author
|
Sorry, my intent was to allow single-letter event names, but I didn't consider numbers. |
Collaborator
|
I think you could change the |
Author
|
I think for the sake of clarity, I'll just leave that alone in this pull request. :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds event subtyping as proposed in https://github.com/square/cube/issues/59 .