Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate targets in warnings.rst #175

Merged
merged 1 commit into from
Jun 25, 2020

Conversation

jqmp
Copy link
Collaborator

@jqmp jqmp commented Jun 24, 2020

When building the docs, Sphinx will emit a warning if two links have the
same text. This is a weird constraint but apparently it's part of the
ReST spec. This commit fixes this by using double-underscore links.

More explanation: sphinx-doc/sphinx#3921

When building the docs, Sphinx will emit a warning if two links have the
same text. This is a weird constraint but apparently it's part of the
ReST spec. This commit fixes this by using double-underscore links.

More explanation: sphinx-doc/sphinx#3921
@jqmp jqmp requested a review from namanjain June 24, 2020 15:27
Copy link
Collaborator

@namanjain namanjain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jqmp jqmp merged commit c097e30 into master Jun 25, 2020
@jqmp jqmp deleted the janek/remove-duplicate-targets branch June 25, 2020 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants