Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Valet 4.0] Require that App ID Prefix be explicitly passed into Shared Access Group Valets #218

Merged
merged 6 commits into from
Apr 12, 2020
Merged

[Valet 4.0] Require that App ID Prefix be explicitly passed into Shared Access Group Valets #218

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b15410c
Require that App ID Prefix be explicitly passed into Shared Access Gr…
dfed Feb 25, 2020
be35452
Add App ID prefix to tests
dfed Feb 25, 2020
5078ffc
Create and adopt SharedAccessGroupIdentifier
dfed Feb 25, 2020
50917b1
Update documentation
dfed Feb 25, 2020
e141613
Fix Mac tests
dfed Feb 25, 2020
b1a0c21
Bring SharedAccessGroupIdentifier to sharedAccessGroupOverride
dfed Feb 25, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add App ID prefix to tests
  • Loading branch information
@dfed
dfed committed Feb 25, 2020
commit be3545277f65ac4a41c7ba98f66842951758944d
8 changes: 4 additions & 4 deletions Tests/ValetIntegrationTests/ValetIntegrationTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,13 +63,13 @@ internal extension Valet {
static var sharedAccessGroupIdentifier: Identifier = {
let sharedAccessGroupIdentifier: Identifier
#if os(iOS)
sharedAccessGroupIdentifier = Identifier(nonEmpty: "com.squareup.Valet-iOS-Test-Host-App")!
sharedAccessGroupIdentifier = Identifier(nonEmpty: "9XUJ7M53NG.com.squareup.Valet-iOS-Test-Host-App")!
#elseif os(macOS)
sharedAccessGroupIdentifier = Identifier(nonEmpty: "com.squareup.Valet-macOS-Test-Host-App")!
sharedAccessGroupIdentifier = Identifier(nonEmpty: "9XUJ7M53NG.com.squareup.Valet-macOS-Test-Host-App")!
#elseif os(tvOS)
sharedAccessGroupIdentifier = Identifier(nonEmpty: "com.squareup.Valet-tvOS-Test-Host-App")!
sharedAccessGroupIdentifier = Identifier(nonEmpty: "9XUJ7M53NG.com.squareup.Valet-tvOS-Test-Host-App")!
#elseif os(watchOS)
sharedAccessGroupIdentifier = Identifier(nonEmpty: "com.squareup.ValetTouchIDTestApp.watchkitapp.watchkitextension")!
sharedAccessGroupIdentifier = Identifier(nonEmpty: "9XUJ7M53NG.com.squareup.ValetTouchIDTestApp.watchkitapp.watchkitextension")!
#else
XCTFail()
#endif
Expand Down