Skip to content

Conversation

@lickel
Copy link
Collaborator

@lickel lickel commented Oct 7, 2022

Expectations

  • Swift v5.7 minimum

Changes

  • SwiftFormat has been added to GH Actions "Validate"
  • watchOS compilation is enabled in GH Actions

Goals

  • @MainActor annotations
  • Generic protocols
  • JSON literal type checking

Failed Goals

  • var delegate: any Delegate<T>?
    • Not possible due to optionality and possibly other reasons?
    • It kind of feels like a compiler bug since the types are explicit, but the compiler is still opening it up to the most explicit flavor.
    • The workaround would require a lot of as! casting in unsafe delegate method shims

@codecov-commenter
Copy link

codecov-commenter commented Oct 7, 2022

Codecov Report

Base: 90.84% // Head: 93.28% // Increases project coverage by +2.44% 🎉

Coverage data is based on head (9317b01) compared to base (8d8e330).
Patch coverage: 76.96% of modified lines in pull request are covered.

❗ Current head 9317b01 differs from pull request most recent head 95d0e87. Consider uploading reports for the commit 95d0e87 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #40      +/-   ##
==========================================
+ Coverage   90.84%   93.28%   +2.44%     
==========================================
  Files          30       30              
  Lines        4924     5049     +125     
==========================================
+ Hits         4473     4710     +237     
+ Misses        451      339     -112     
Impacted Files Coverage Δ
...uests/Sources/Associations/FetchableEntityID.swift 100.00% <ø> (ø)
FetchRequests/Sources/FetchableObject.swift 100.00% <ø> (ø)
...uests/Tests/SwiftUI/FetchableRequestTestCase.swift 100.00% <ø> (ø)
...equests/Sources/Associations/ObservableToken.swift 84.69% <43.47%> (-4.72%) ⬇️
...Tests/Models/FetchRequestAssociationTestCase.swift 98.86% <50.00%> (+0.22%) ⬆️
FetchRequests/Sources/JSON.swift 84.16% <70.00%> (+0.56%) ⬆️
.../Sources/Controller/FetchedResultsController.swift 85.13% <72.72%> (+3.98%) ⬆️
...ources/Associations/AssociatedValueReference.swift 96.00% <85.71%> (+2.75%) ⬆️
FetchRequests/Tests/TestObject+Associations.swift 83.48% <85.71%> (+10.09%) ⬆️
.../Controller/PausableFetchedResultsController.swift 93.68% <88.88%> (+2.98%) ⬆️
... and 34 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@lickel lickel marked this pull request as ready for review October 12, 2022 17:56
* Use Protocol Generics
* Remove a bunch of where clauses
* Remove `Iterator.Element`s
CHANGELOG.md Outdated
`FetchRequests` adheres to [Semantic Versioning](https://semver.org/).

## [5.0](https://github.com/square/FetchRequests/releases/tag/5.0.0)
Released on TKTKTK
Copy link
Collaborator Author

@lickel lickel Oct 17, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Add date

@lickel lickel enabled auto-merge October 25, 2022 17:55
@lickel lickel merged commit 48a5f44 into main Oct 25, 2022
@lickel lickel deleted the feature/5.0 branch October 25, 2022 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants