Skip to content

Conversation

@lickel
Copy link
Collaborator

@lickel lickel commented May 9, 2022

The functional change here allows for Array associations that do not use the ID.
Uses for this would be if (for example) the source entity exposes a list of encoded IDs.

The only requirement to enable this is to pass a closure for the associated entity to expose the reference.

@codecov-commenter
Copy link

codecov-commenter commented May 9, 2022

Codecov Report

Merging #37 (b63c58e) into main (720319b) will increase coverage by 0.00%.
The diff coverage is 90.24%.

@@           Coverage Diff           @@
##             main      #37   +/-   ##
=======================================
  Coverage   90.83%   90.84%           
=======================================
  Files          30       30           
  Lines        4901     4924   +23     
=======================================
+ Hits         4452     4473   +21     
- Misses        449      451    +2     
Impacted Files Coverage Δ
...s/Sources/Requests/PaginatingFetchDefinition.swift 91.66% <ø> (ø)
...ibleSectionsFetchedResultsControllerTestCase.swift 99.15% <ø> (ø)
...Controllers/FetchedResultsControllerTestCase.swift 100.00% <ø> (ø)
FetchRequests/Tests/TestObject+Associations.swift 73.39% <ø> (ø)
FetchRequests/Tests/TestObject.swift 89.47% <ø> (ø)
.../Controller/FetchedResultsControllerProtocol.swift 81.31% <33.33%> (ø)
.../Sources/Controller/FetchedResultsController.swift 81.15% <66.66%> (ø)
.../CollapsibleSectionsFetchedResultsController.swift 86.85% <75.00%> (-0.41%) ⬇️
...tchRequests/Sources/SwiftUI/FetchableRequest.swift 88.05% <83.33%> (ø)
...Sources/Associations/FetchRequestAssociation.swift 76.44% <97.14%> (+0.93%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 720319b...b63c58e. Read the comment docs.

@lickel lickel force-pushed the array-associations branch from 29c03a2 to 51e81a9 Compare May 9, 2022 17:28
@lickel lickel enabled auto-merge May 10, 2022 03:35
@lickel lickel merged commit 042e3ef into main May 10, 2022
@lickel lickel deleted the array-associations branch May 10, 2022 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants