Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the sidebar theme as "sidebar_theme" #546

Merged
merged 3 commits into from
Aug 20, 2024
Merged

Conversation

Ajotah98
Copy link
Contributor

Change the "theme" property of sidebar as "sidebar_theme" (#540) and accept it as parameter and not a boolean.

I don't really know "where" to place the documentation, as the folder docs doesn't include the documentation.sql of the components nor the Markdown files with docs.

@lovasoa
Copy link
Collaborator

lovasoa commented Aug 20, 2024

Yes, I'm sorry, the location of the documentation is not obvious. It's here:

https://github.com/lovasoa/SQLpage/blob/e5c54727c242d5daa7bd8c5cebc72205e7884a0c/examples/official-site/sqlpage/migrations/01_documentation.sql#L870

@lovasoa lovasoa merged commit 53082b5 into sqlpage:main Aug 20, 2024
10 checks passed
@lovasoa
Copy link
Collaborator

lovasoa commented Aug 20, 2024

Thank you @Ajotah98 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants