Open
Conversation
ahmad-moussawi
approved these changes
Apr 25, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the Clone() method in the Query class to perform deep cloning instead of shallow cloning, addressing issue #747. The fix ensures that nested objects like Parent queries and Includes are properly cloned rather than sharing references.
- Implements deep cloning for Parent query references
- Adds proper cloning for Includes collection with new Clone() method
- Creates independent copy of Variables dictionary
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| QueryBuilder/Query.cs | Updates Clone() method to deep clone Parent, Includes, and Variables properties |
| QueryBuilder/Include.cs | Adds new Clone() method to enable deep cloning of Include objects |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Contributor
|
@cemahseri the PR is failing to build |
c3ae82e to
981f444
Compare
Author
|
copilot is high on k2/spice, don't trust it. the pr builds just fine |
Contributor
I was trying to build it locally but maybe I was missing something, I will try again tonight |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #747