Open
Conversation
Allow Overrides when creating the string parameters
Create method for instantiating the SqlResult object to allow for using derived classes instead
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While creating a compiler to use with MSAccess, I found that I was having zero search results in all of my queries that used a 'where' statement.
I tracked the issue down to the SqlResult object using single quotes for strings, as opposed to an escaped double-quote.
'vs\"Unfortunately, this was not an 'easy' fix that was built in already due to the method being private, and no easy override available currently.
This PR adds an overridable method to the compiler that instantiates the SqlResult object. From there, any consumers that need custom wrapping for their values can be easily achieved, just override the
GetNewSqlResultmethod to use your custom type.