-
Notifications
You must be signed in to change notification settings - Fork 12
feat: antivm #154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
sqlerrorthing
wants to merge
3
commits into
master
Choose a base branch
from
feat/antivm
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
feat: antivm #154
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer's GuideThis PR introduces a new antivm crate with virtualization detection strategies, integrates it into the workspace and builder, refactors the message_box module for consistent formatting, and extends the filesystem Path API with a system_root helper. Class diagram for the new antivm crateclassDiagram
class VmDetector {
<<trait>>
+is_running_in_vm() bool
}
class KVMCheck {
+is_running_in_vm() bool
}
class SmallScreenCheck {
+is_running_in_vm() bool
}
class ParallelsCheck {
+is_running_in_vm() bool
}
class Check {
+KVM
+SmallScreen
+Parallels
+Custom(Box<VmDetector>)
+is_running_in_vm() bool
}
class run_checks {
+run_checks(checks: Vec<Check>) bool
}
VmDetector <|.. KVMCheck
VmDetector <|.. SmallScreenCheck
VmDetector <|.. ParallelsCheck
VmDetector <|.. Check : via Custom
Check ..> KVMCheck : dispatch
Check ..> SmallScreenCheck : dispatch
Check ..> ParallelsCheck : dispatch
run_checks ..> Check : uses
Class diagram for the extended Path API in filesystemclassDiagram
class Path {
+system_root() Path
+roaming_appdata() Path
+localappdata() Path
}
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #142
Closes #152 (if use anti vm)