internal/dinosql: support Postgres macaddr type in Go - #358
Merged
Conversation
kevinburke1
changed the title
kyleconroy
requested changes
Feb 24, 2020
kyleconroy
left a comment
kyleconroy
left a comment
Collaborator
There was a problem hiding this comment.
Could you please add a separate test instead of adding columns to the ondeck example?
Also add an end to end test. Fixes sqlc-dev#353.
Contributor
Author
|
ok added |
kyleconroy
approved these changes
Feb 24, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests not passing, just wanted to submit