parser: Generate correct types for SELECT NOT EXISTS
#1972
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haines
force-pushed
the
select-not-exists
branch
from
9f7181e to
565ec8d
Compare
haines
force-pushed
the
select-not-exists
branch
from
565ec8d to
ae37ca7
Compare
haines
force-pushed
the
select-not-exists
branch
from
ae37ca7 to
91b388b
Compare
Signed-off-by: Andrew Haines <andrew@haines.org.nz>
haines
force-pushed
the
select-not-exists
branch
from
91b388b to
02db523
Compare
kyleconroy
approved these changes
Feb 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1140
Currently,
SELECT NOT EXISTSqueries produceany-typed results. This PR makes them producebool-typed results, and defaults the column name tonot_existsto mirror the behaviour ofSELECT EXISTSqueries.