Python query param limit #1530
Merged
Python query param limit #1530
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update pluginPythonCode unexported default limit
kyleconroy
reviewed
Aug 29, 2022
|
@danicc097 Sorry for taking forever on this code review. I can promise a quick review if you're able to fix the merge conflicts. If not, I totally understand. |
|
@kyleconroy I noticed Python currently has a default limit of 4, the change to 1 would be breaking. Want to keep it anyway for consistency? |
|
We should keep the default the same, even if it isn't the same as Go's |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #1498 , but gives support for a
query_parameter_limitin Python codegen, very much desirable for my use case with FastAPI.Initially I wanted to also include Go, but I've failed miserably since all Go code generation uses a single param and don't know about the best way to proceed that requires minimal changes