Skip to content

feat: Add MySQL support for BETWEEN arguments #1265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 3, 2021
Merged

feat: Add MySQL support for BETWEEN arguments #1265

merged 2 commits into from
Nov 3, 2021

Conversation

timstudd
Copy link
Contributor

@timstudd timstudd commented Nov 2, 2021

No description provided.

@timstudd
Copy link
Contributor Author

timstudd commented Nov 2, 2021

Fixes #1077

kyleconroy
kyleconroy approved these changes Nov 3, 2021
View reviewed changes
Copy link
Collaborator

@kyleconroy kyleconroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for the great PR

@kyleconroy kyleconroy merged commit c05375b into sqlc-dev:main Nov 3, 2021
@timstudd timstudd deleted the feature/mysql-between-args branch November 3, 2021 12:01
@BillBuilt
Copy link

Hi! Unless I'm missing something here, the BETWEEN argument is not working. The playground link for #1077 shows no parameters able to be passed for the 2 BETWEEN arguments in the query methods. Is this supposed to be working? I too cannot get BETWEEN to work correctly, as I get the same results... a query method that ignores the arguments for BETWEEN.

Playground: https://play.sqlc.dev/p/191c72c32e4c4c35ec8c7f197c20ee52e38c54c978484bc7ae9dd7f296b9b0b2

Thank you

@kyleconroy
Copy link
Collaborator

The playground is still using version 1.10. I'm hoping to release 1.11 today

@BillBuilt
Copy link

Ahh that explains it. My bad.... for whatever reason I had it in my head it was supposed to have been in the latest release.... thanks! Easy to work-around for now, at least for my uses, but there are times when BETWEEN just makes large queries more readable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kyleconroy kyleconroy kyleconroy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@timstudd @BillBuilt @kyleconroy