Merged
Conversation
- Strip trailing semicolons from line comments in lexer, since semicolons are statement terminators and should not be part of comment text. This prevents double semicolons in formatted output. - Add normalizeForFormat function in test that strips trailing semicolons before comparison, making tests pass regardless of whether the original query had a trailing semicolon. - Enable 47 tests that now pass the format roundtrip test by removing the todo_format flag from their metadata.json files.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Strip trailing semicolons from line comments in lexer, since
semicolons are statement terminators and should not be part of
comment text. This prevents double semicolons in formatted output.
Add normalizeForFormat function in test that strips trailing
semicolons before comparison, making tests pass regardless of
whether the original query had a trailing semicolon.
Enable 47 tests that now pass the format roundtrip test by
removing the todo_format flag from their metadata.json files.