Fix 5 parser tests with PRIMARY KEY, CREATE VIEW validation, and negated literals#47
Merged
kyleconroy merged 3 commits intomainfrom Dec 26, 2025
Merged
Conversation
…ted literals - Add PRIMARY KEY column constraint support in column definitions Outputs PRIMARY KEY columns as Function tuple in Columns definition - Validate CREATE VIEW TO clause (only valid for MATERIALIZED VIEW) Returns parse error for regular VIEW with TO clause - Fix negated literal formatting in Subquery context Outputs as Literal Int64_-N instead of Function negate when inside Subquery Preserves Function negate output for view() function arguments Tests enabled: - 00098_j_union_all - 01668_avg_weighted_ubsan - 02189_join_type_conversion - 02554_invalid_create_view_syntax (parse_error) - 03532_redis_empty_variant_key
- Fix inSubqueryContext handling in explainTableExpression for subqueries with aliases - Enable test 01761_cast_to_enum_nullable (already passing) - Enable test 01818_case_float_value_fangyc (already passing) - Enable test 03290_limit_by_segv (already passing)
- Add AsTableFunction field to CreateQuery AST for CREATE TABLE AS function() - Parse table function calls in CREATE TABLE AS and store in AsTableFunction - Add SHOW CREATE TABLE output format with database/table identifiers - Enable 2 passing tests: 02118_show_create_table_rocksdb, 03293_forbid_cluster_table_engine
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add PRIMARY KEY column constraint support in column definitions
Outputs PRIMARY KEY columns as Function tuple in Columns definition
Validate CREATE VIEW TO clause (only valid for MATERIALIZED VIEW)
Returns parse error for regular VIEW with TO clause
Fix negated literal formatting in Subquery context
Outputs as Literal Int64_-N instead of Function negate when inside Subquery
Preserves Function negate output for view() function arguments
Tests enabled: