Support comprehensions inside functions when use strict_undefined flag.

[cocolato]

Fixes: #320

Now the test code works as expected if strict_undefined is set to true:

from mako.template import Template

text = """
<%
    mydict = { 'foo': 1 }

    ## Uncomment the following line to workaround the error
    ##k = None
    def getkeys(x):
        return [ k for k in x.keys() ]
%>

${ ','.join( getkeys(mydict) ) }
"""

tmpl = Template(text=text, strict_undefined=True)
out = tmpl.render()
print(out)

output:

foo

[zzzeek]

wow I dig this, you're into mako now. great let's run the CI

[sqla-tester]

OK, this is sqla-tester setting up my work on behalf of zzzeek to try to get revision daffd38 of this pull request into gerrit so we can run tests and reviews and stuff

[sqla-tester]

New Gerrit review created for change daffd38: https://gerrit.sqlalchemy.org/c/sqlalchemy/mako/+/5147

[zzzeek]

can you add a changelog file? thanks

[zzzeek]

this is great.

it needs:

1. a changelog file, like the other one
2. the fixes: line:

    Fixes: #320
    Closes: #386
    Pull-request: https://github.com/sqlalchemy/mako/pull/386
    Pull-request-sha: daffd3832b4adab291625e1e6efcdb56f8d0d05e
    
    Change-Id: I0591873a83837f8f35b0963c0536df1e2675012f

[zzzeek]

typo

[cocolato]

All has been updated.

[sqla-tester]

OK, this is sqla-tester setting up my work on behalf of zzzeek to try to get revision cc6a3e0 of this pull request into gerrit so we can run tests and reviews and stuff

[sqla-tester]

Patchset cc6a3e0 added to existing Gerrit review https://gerrit.sqlalchemy.org/c/sqlalchemy/mako/+/5147

[sqla-tester]

Michael Bayer (zzzeek) wrote:

thanks!

View this in Gerrit at https://gerrit.sqlalchemy.org/c/sqlalchemy/mako/+/5147

[sqla-tester]

Gerrit review https://gerrit.sqlalchemy.org/c/sqlalchemy/mako/+/5147 has been merged. Congratulations! :)