Support comprehensions inside functions when use strict_undefined flag.#386
Support comprehensions inside functions when use strict_undefined flag.#386cocolato wants to merge 2 commits intosqlalchemy:mainfrom
Conversation
|
wow I dig this, you're into mako now. great let's run the CI |
sqla-tester
left a comment
sqla-tester
left a comment
There was a problem hiding this comment.
OK, this is sqla-tester setting up my work on behalf of zzzeek to try to get revision daffd38 of this pull request into gerrit so we can run tests and reviews and stuff
|
New Gerrit review created for change daffd38: https://gerrit.sqlalchemy.org/c/sqlalchemy/mako/+/5147 |
|
can you add a changelog file? thanks |
zzzeek
left a comment
zzzeek
left a comment
There was a problem hiding this comment.
this is great.
it needs:
- a changelog file, like the other one
- the fixes: line:
Fixes: #320
Closes: #386
Pull-request: https://github.com/sqlalchemy/mako/pull/386
Pull-request-sha: daffd3832b4adab291625e1e6efcdb56f8d0d05e
Change-Id: I0591873a83837f8f35b0963c0536df1e2675012f
test/test_template.py
Outdated
| "bar %% baz", | ||
| ] | ||
|
|
||
| def test_lsitcomp_in_func_strict(self): |
Closes: sqlalchemy#386 Pull-request: sqlalchemy#386 Pull-request-sha: 7840ad3 Change-Id: I0591873a83837f8f35b0963c0536df1e2675012f
cocolato
force-pushed
the
fix/incompatible_comp
branch
from
daffd38 to
cc6a3e0
Compare
|
All has been updated. |
sqla-tester
left a comment
sqla-tester
left a comment
There was a problem hiding this comment.
OK, this is sqla-tester setting up my work on behalf of zzzeek to try to get revision cc6a3e0 of this pull request into gerrit so we can run tests and reviews and stuff
|
Patchset cc6a3e0 added to existing Gerrit review https://gerrit.sqlalchemy.org/c/sqlalchemy/mako/+/5147 |
|
Michael Bayer (zzzeek) wrote: thanks! View this in Gerrit at https://gerrit.sqlalchemy.org/c/sqlalchemy/mako/+/5147 |
|
Gerrit review https://gerrit.sqlalchemy.org/c/sqlalchemy/mako/+/5147 has been merged. Congratulations! :) |
Fixes: sqlalchemy/mako#320 Now the test code works as expected if strict_undefined is set to true: ```python from mako.template import Template text = """ <% mydict = { 'foo': 1 } ## Uncomment the following line to workaround the error ##k = None def getkeys(x): return [ k for k in x.keys() ] %> ${ ','.join( getkeys(mydict) ) } """ tmpl = Template(text=text, strict_undefined=True) out = tmpl.render() print(out) ``` output: ``` foo ``` Closes: #386 Pull-request: sqlalchemy/mako#386 Pull-request-sha: cc6a3e0694fb5615db2c3fec2cd23bc9e8a70066 Change-Id: I0591873a83837f8f35b0963c0536df1e2675012f
3 participants
Fixes: #320
Now the test code works as expected if strict_undefined is set to true:
output: