add session struct in proto #71
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
typhoonzero
previously approved these changes
Jun 27, 2019
| else: | ||
| for res in MockServicer.table_response(MockServicer.get_test_table()): | ||
| yield res | ||
| elif SQL == "TEST VERIFY SESSION": |
There was a problem hiding this comment.
Maybe add comments why need this string, and how we improve this in the future.
There was a problem hiding this comment.
I added a todo comment here, will improve it with an elegant way in the future.
typhoonzero
approved these changes
Jun 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #68
Related issue: sql-machine-learning/sqlflow#531