Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using vanity import path in readme #5

Merged
merged 1 commit into from
May 22, 2019
Merged

Using vanity import path in readme #5

merged 1 commit into from
May 22, 2019

Conversation

weiguoz
Copy link
Collaborator

@weiguoz weiguoz commented May 21, 2019

change github.com/sql-machine-learning/gomaxcompute to sqlflow.org/gomaxcompute

@weiguoz weiguoz changed the title [WIP]Using vanity import path in readme Using vanity import path in readme May 21, 2019
tonyyang-svail
tonyyang-svail approved these changes May 22, 2019
View reviewed changes
Copy link
Collaborator

@tonyyang-svail tonyyang-svail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

tonyyang-svail
tonyyang-svail approved these changes May 22, 2019
View reviewed changes
Copy link
Collaborator

@tonyyang-svail tonyyang-svail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@tonyyang-svail tonyyang-svail merged commit b7277d9 into sql-machine-learning:develop May 22, 2019
@weiguoz weiguoz deleted the vanity_readme branch May 22, 2019 04:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tonyyang-svail tonyyang-svail tonyyang-svail approved these changes

@hungry1526 hungry1526 Awaiting requested review from hungry1526

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@weiguoz @tonyyang-svail