Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle bad query #42

Merged
merged 2 commits into from
Jun 17, 2019
Merged

Handle bad query #42

merged 2 commits into from
Jun 17, 2019

Conversation

tonyyang-svail
Copy link
Collaborator

@tonyyang-svail tonyyang-svail commented Jun 17, 2019 •
edited
Loading

Current implementation returns a nil error even if the instance ends with an ODPS- error.

@tonyyang-svail tonyyang-svail requested a review from weiguoz June 17, 2019 05:41
weiguoz
weiguoz approved these changes Jun 17, 2019
View reviewed changes
Copy link
Collaborator

@weiguoz weiguoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@weiguoz weiguoz merged commit a224d4d into develop Jun 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weiguoz weiguoz weiguoz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tonyyang-svail @weiguoz