Skip to content

Conversation

@brightcoder01
Copy link
Collaborator

No description provided.

Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it really necessary to add this to elasticdl? The preprocessing layers seem so simple and I think they should be in examples instead.

@brightcoder01
Copy link
Collaborator Author

Is it really necessary to add this to elasticdl? The preprocessing layers seem so simple and I think they should be in examples instead.

Good question.
The layers is useful for the code_gen of SQLFlow transform expression and can be imported directly in the generated code. If not, I'm afraid we should generate this piece of code multiple times.

@terrytangyuan
Copy link
Member

@brightcoder01 Sure but maybe this can be moved to examples instead of a module/folder?

@brightcoder01
Copy link
Collaborator Author

@brightcoder01 Sure but maybe this can be moved to examples instead of a module/folder?

Good suggestion. We will add a model example for all the preprocessing layers after submitting all the layers.

@brightcoder01 brightcoder01 merged commit f30cfa6 into sql-machine-learning:develop Mar 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants