-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
- allow "exec" commmand to pass dictionary-params to webworker (with testcase) #364
Conversation
- add test passing dictionary-params to webworker
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. But since it's a new feature, we need to document it.
added documentation for multi-line exec-statements with params in commit # 2: 7bdff4d. also verified documented example-usage runs correctly in browser: |
Co-Authored-By: Ophir LOJKINE <ophir.lojkine@auto-grid.com>
- resolve conversation - replace "several queries" with "several statements" - try to limit documentation to 80-column width
log of commits-notes:
1 remaining unresolved conversation: example use-case @ line 178 in src/api.js |
I don't see any unresolved conversation. Is this ready for merging? |
yes, its ready for merge on my side! : ) i have another worker patch in the works (to ingest large csv's while keeping ui-responsive) that depends on this. |
* | ||
* We query it like that: | ||
* ```javascript | ||
* var db = new SQL.Database(); | ||
* var res = db.exec("SELECT id FROM test; SELECT age,name FROM test;"); | ||
* var res = db.exec( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, it's merged. Thank you @kaizhu256. What is your other patch ? Maybe we can discuss it first ? I was thinking about deprecating our buggy and largely untested worker code in favor of more modern and feature-complete alternatives. |
i generally use sql.js via webworkers, b/c i need the browser-ui to be responsive while ingesting/manipulating largish (200mb) csv's and queries that could take 30+ seconds.
the biggest missing feature for me using webworkers is passing parameters. i've been successfully using the patch in this pull-request in production for the past 6 months.