Skip to content

Conversation

@brody4hire
Copy link

@brody4hire brody4hire commented Jan 9, 2020

Most important:

  • use more constants - should help support some custom builds

less important - updated:

  • simplify wrapping of dist/*.js
  • remove an extra blank line
  • add dist/sql-asm-memory-growth-debug.js build target

The proposed dist/sql-asm-memory-growth-debug.js build target would also help me support a custom build for a major customer. I will completely understand if this proposed build target is not wanted.

I would also be happy to split some of these changes out if needed.

@brody4hire
Copy link
Author

I just updated this proposal to remove the change I proposed in ea45e77, remove an extra blank line, and rename the proposed build target to dist/sql-asm-memory-growth-debug.js. I would appreciate review and consideration since these changes could help me support my custom build a little more easily.

@brody4hire
Copy link
Author

brody4hire commented Jan 12, 2020

I am splitting this one up.


P.S. I am holding off on the proposed dist/sql-asm-memory-growth-debug.js build target until PR #329 is reviewed and hopefully merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant