Skip to content

Commit 862bc61

Browse files
committed
fix: drop support for 3.2
1 parent e187d76 commit 862bc61

File tree

4 files changed

+9
-4
lines changed

4 files changed

+9
-4
lines changed

.github/workflows/tests.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ jobs:
1515
test:
1616
strategy:
1717
matrix:
18-
version: ['3.2', '4.0', '4.1', '4.2', '4.3', '4.4', '5.0', '5.1', 'latest']
18+
version: ['4.0', '4.1', '4.2', '4.3', '4.4', '5.0', '5.1', 'latest']
1919
fail-fast: false
2020
runs-on: ubuntu-latest
2121
steps:

CHANGELOG.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
### Fixed
66

77
- Fix encoding numbers with leading zeros throws an error. (#6)
8-
- Works with bash version 3.2 or higher (#7)
8+
- Works with bash version 4.0 or higher (#7)
99

1010
## [1.0.0] - 2024-01-28
1111

README.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,12 +31,18 @@ Not good for:
3131

3232
## 🚀 Getting started
3333

34+
If your bash version is not 4.0 or higher, please upgrade your bash. (You can check with `$bash --version`.)
35+
36+
Once you have verified the version of bash, run
37+
3438
```bash
3539
git clone https://github.com/sqids/sqids-bash.git
3640
chmod +x sqids-bash/src/sqids
3741
cp sqids-bash/src/sqids /usr/local/bin
3842
```
3943

44+
You may need to add `sudo` before the command to run the commands as root.
45+
4046
## 👩‍💻 Examples
4147

4248
Simple encode & decode:

src/sqids

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -603,8 +603,7 @@ joinchars() {
603603

604604
# usage: lower "AbCdE" -> "abcde"
605605
lower() {
606-
__RETURN=$(echo "$1" | tr '[:upper:]' '[:lower:]')
607-
# __RETURN="${1,,}" # does not work with bash 3.2
606+
__RETURN="${1,,}"
608607
}
609608

610609
# usage: shuffle "abcdefg" -> "bcefgad"

0 commit comments

Comments
 (0)