fix: fix bash 3.2 error

king-p3nguin · king-p3nguin · commit e187d761b39f · 2024-01-29T05:43:15.000+09:00
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,6 +1,6 @@
 # CHANGELOG
 
-## [1.0.1] - 2024-01-28
+## [1.0.1] - 2024-01-29
 
 ### Fixed
 
diff --git a/README.md b/README.md
@@ -1,6 +1,8 @@
 # [Sqids Bash](https://sqids.org/bash)
 
+![GitHub Release](https://img.shields.io/github/v/release/sqids/sqids-bash)
 [![Tests](https://github.com/sqids/sqids-bash/actions/workflows/tests.yml/badge.svg?branch=main)](https://github.com/sqids/sqids-bash/actions/workflows/tests.yml)
+![GitHub Downloads (all assets, all releases)](https://img.shields.io/github/downloads/sqids/sqids-bash/total)
 
 [Sqids](https://sqids.org/bash) (*pronounced "squids"*) is a small library that lets you **generate unique IDs from numbers**. It's good for link shortening, fast & URL-safe ID generation and decoding back into numbers for quicker database lookups.
 
diff --git a/src/sqids b/src/sqids
@@ -603,7 +603,8 @@ joinchars() {
 
 # usage: lower "AbCdE" -> "abcde"
 lower() {
-    __RETURN="${1,,}"
+    __RETURN=$(echo "$1" | tr '[:upper:]' '[:lower:]')
+    # __RETURN="${1,,}" # does not work with bash 3.2
 }
 
 # usage: shuffle "abcdefg" -> "bcefgad"

Original file line number	Diff line number	Diff line change
`@@ -603,7 +603,8 @@ joinchars() {`
`603`	`603`
`604`	`604`	`# usage: lower "AbCdE" -> "abcde"`
`605`	`605`	`lower() {`
`606`		`- __RETURN="${1,,}"`
	`606`	`+ __RETURN=$(echo "$1" \| tr '[:upper:]' '[:lower:]')`
	`607`	`+ # __RETURN="${1,,}" # does not work with bash 3.2`
`607`	`608`	`}`
`608`	`609`
`609`	`610`	`# usage: shuffle "abcdefg" -> "bcefgad"`