Rewrite computation of max and min in dataframe editor #3353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes update_max_min_col more robust regarding non-numeric values. Fixes spyder-ide#3308 and spyder-ide#2940.
|
@jitseniesen, this is a terrific job!! Thanks a lot for it! :-) I especially liked your new Since everything is green, there's only one thing for me to do: press the Merge button ;-) |
|
Indeed, great addition :-) 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main goal for this PR is to fix an unhandled exception in
update_min_max_col()in the dataframe editor, which is triggered by dataframes with either categorical data or with timezone-aware timestamps.I ended up completely rewriting the function so that it only compute the max and min of columns where the results are actually used (in order to set the background colour), because there were some details of the old implementation that I did not quite understand (handling of complex numbers). I also added tests, expanded the docstring, and did some clean-up in related routines.
Fixes #2940 and #3308.