Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Update readme and organize badges #3336

Merged
merged 1 commit into from
Aug 11, 2016
Merged

PR: Update readme and organize badges #3336

merged 1 commit into from
Aug 11, 2016

Conversation

goanpeca
Copy link
Member

@goanpeca goanpeca commented Jul 30, 2016

  • Reorganize badges for build and project status
  • Include Quantified Code badge
  • Include Gitter chat bagde

image

@goanpeca goanpeca added this to the v3.0beta5 milestone Jul 30, 2016
@goanpeca goanpeca self-assigned this Jul 30, 2016
@ccordoba12
Copy link
Member

My replies:

  • Please remove the Quantified Code badge. IMHO, the badge doesn't have meaningful information (at least for regular users, who are the primary target of our README).
  • Please remove PyPi downloads. That's broken for now and who knows when it's going to be fixed.
  • The Project details should go before Build status because it has information for users instead of devs.
  • Please remove the CircleCi badge and add it instead in its corresponding PR.

@goanpeca goanpeca closed this Aug 1, 2016
@ccordoba12 ccordoba12 removed this from the v3.0beta5 milestone Aug 1, 2016
@ccordoba12
Copy link
Member

What happened here? Why did you close it?

@goanpeca
Copy link
Member Author

goanpeca commented Aug 2, 2016

Why did you close it?

Frustration...


On your comments:

Please remove the Quantified Code badge. IMHO, the badge doesn't have meaningful information (at least for regular users, who are the primary target of our README).

It does, it conveys that the codebase is following some quality standards and makes issues in the codebase visible. The idea is to be transparent, as with the covergae despite it being low we give visibility to it and that in turns will steer the project to increasing coverage. Same with quantified code.

Please remove PyPi downloads. That's broken for now and who knows when it's going to be fixed.

Ok

The Project details should go before Build status because it has information for users instead of devs.

Makes sense

Please remove the CircleCi badge and add it instead in its corresponding PR.

I will but please enable circle ci, it is kinda if a bummer that you just shut it down. I can have it working real quick (I have enable circle ci on several projects now... anaconda-client, conda-manager, navigator...)

@goanpeca goanpeca reopened this Aug 2, 2016
@ccordoba12 ccordoba12 added this to the v3.0beta5 milestone Aug 3, 2016
@ccordoba12
Copy link
Member

ccordoba12 commented Aug 8, 2016

It does, it conveys that the codebase is following some quality standards and makes issues in the codebase visible.

Ok, then it's fine to have it :-p

... please enable circle ci

I don't have time to deal with another CI service right now. Besides, after a long time, Travis and AppVeyor are working really well now, so I don't want to touch them.

Sorry, I know it's a bummer, but let's just focus on getting 3.0 out of the door for now.


Please do my couple of suggested changes to merge this one :-)

@ccordoba12
Copy link
Member

I'll merge this one and do my suggested changes in master :-)

@ccordoba12 ccordoba12 merged commit c33027f into spyder-ide:master Aug 11, 2016
ccordoba12 added a commit that referenced this pull request Aug 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants