-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR: Fix/Find in files #3295
PR: Fix/Find in files #3295
Conversation
return extensions | ||
extensions = extensions + list(lexer_exts) + list(other_exts) | ||
|
||
return sorted(list(set(extensions))) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do these changes do exactly?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lexer_exts = [le[1:] for le in lexer_exts]
This code is wrong cause not all lexers extensions start with a *
, so I fixed that so the actual generated patterns are valid regex. (this was causing find in files to not work after a clean install)
Does your changes hide the default (advanced) view of Find in files? If not, I'd like to see that as part of this PR ;-) |
Hi @ccordoba12 , I forgot to add the description. Basically the include regex were based on the extensions provided by the pygments lexers, but the problem is that the generated regex was invalid. I corrected that and added some tests so we are sure that the Include and Exclude patterns are always valid regular expressions. I can hide the pane by default. Working on a ack/grin like interface after this PR. |
@ccordoba12, now the advanced options are hidden by default |
I tested our edit filters and they are working correctly, so merging ;-) |
No description provided.