Create only one instance of IntrospectionManager for the application #3234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ication - Before we were creating one instance per EditorStack, which was causing freezes when adding more EditorStacks (e.g. when a new Editor window was created or when the Editor was splitted).
- Also move it to a better place
ccordoba12
changed the title
|
Code and behavior LGTM. |
|
Thanks @blink1073! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before we were creating one instance of IntrospectionManager per EditorStack, which was causing freezes when adding more EditorStacks (e.g. when a new Editor window was created or when the Editor was splitted).
@blink1073, could you take a look at this one?