Fixes for qtpy 1.1.0 #3233
Fixes for qtpy 1.1.0 #3233
Conversation
- This is needed to be compatible with qtpy 1.1.0
| @@ -39,7 +39,7 @@ def check_qt(): | |||
| try: | |||
| import qtpy | |||
| package_name, required_ver = qt_infos[qtpy.API] | |||
| actual_ver = qtpy.__version__ | |||
| actual_ver = qtpy.PYQT_VERSION | |||
There was a problem hiding this comment.
I know we don't support pyside officially anymore, but if I'm not mistaken this will break pyside, since qtpy.PYQT_VERSION is None with pyside. I think using qtpy.QT_VERSION instead should do the trick.
There was a problem hiding this comment.
We are not allowing PySide in qt_infos so it's really unsupported at this time. But that's for another PR :-)
There was a problem hiding this comment.
What is for another PR, PySide support in qt_infos ? Why not adding it directly here ?
There was a problem hiding this comment.
Because this one is only about supporting the newest qtpy. Please prepare it and I'll merge it :-)
|
And this is not even including quantified code!! haha |
|
Sorry, I messed things up by pushing my personal branch as a repo one. I hope this gets fixed once I push a new commit. |
Fixes #3230
We were incorrectly setting
qtpy.__version__to the PyQt version instead of the package one, which breaks the tradition of using__version__as the package version.qtpy 1.1.0 is going to fix this and we need to adapt to this change in Spyder 3.0 :-)
Note: Our tests are going to be broken in this PR until we release qtpy 1.1.0