Editor: Move to next line in run_selection() if nothing selected

[jitseniesen]

Fixes #3115

---

@jitseniesen I rewrote the header to the standard we try to use (Fixes #<issue number>)

[jitseniesen]

It seems to me from the log that the AppVeyor failure occured while the test environment is set up so it is not caused by anything in the pull request.

[goanpeca]

@jitseniesen Awesome :-), thanks for working on this.

Indeed, the appveyor tests are broken for some weeks now, @ccordoba12 will fix them soon :-)

[goanpeca]

Minor style comment

Can we turn this into

"""
Run selected text or current line in console. If no text is selected, then
advance cursor to next line.
"""

[goanpeca]

LGTM 👍

Any comments @spyder-ide/core-developers

[blink1073]

Yep, looks sensible to me.

[goanpeca]

_looks sensible to me_ WTF?

[blink1073]

As in I agree with the approach, but did not actually test it ;).

[jitseniesen]

Of course I'm happy to follow the house style (regarding formatting of docstrings), so I changed it. I tried to infer how you wanted it from other docstrings, but obviously failed.

[goanpeca]

@jitseniesen thanks for the changes... we do not have an specific style written somewhere, but what I am trying to promote is something in the lines of.

• Docstrings are sentences, they need to end with a ..
• Docstrings should have a quick one liner summary and a more lengthy description afterwards.
• Doctsrings respect 80 characters length (PEP enforces a smaller value but mehhh...)
• Doctsrings should ALWAYS use double tripple quotes and ALWAYS be written using a separate line as in:

# As in
def test()
    """
    Hello world.
    """

# Instead of 
def test()
    """Hello world."""

This makes the rule easy.... ALWAYS use that instead of one for one liners or another for whatever reason.

What do you think?

[jitseniesen]

I think it makes sense for a more-than-one-(wo)man project to have style rules and it does not make much sense to argue long about them, so I'm happy to follow those rules.

[ccordoba12]

Thanks for working on this @jitseniesen! Great addition :-)

[Nodd]

What is preventing merging this PR ? Everything looks fine ?

[ccordoba12]

If you feel it's ok, please merge it :-)

El 30/05/16 a las 09:23, Joseph Martinot-Lagarde escribió:

What is preventing merging this PR ? Everything looks fine ?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#3146 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AAWS7SZP_bxV-VKLKOUxoAv8vjRL-RJwks5qGvLQgaJpZM4IVSm3.