PR: More accurate test for text-like files #2939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Qlogin, thanks for your work on fixing this problem. Could you upload a file that's showing the error you're reporting here? @blink1073, you introduced the |
|
I think it looks sound, thanks @Qlogin! |
|
@ccordoba12, sorry, I've used GitHub not so long. All I could do is to attach archive with test file. |
goanpeca
changed the title
|
@blink1073 / @ccordoba12 is this ready for merging? |
|
I think so. |
ccordoba12
added a commit
that referenced
this pull request
Jan 27, 2016
PR: More accurate test for text-like files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2703
In UTF-8 one character can be represented by multiple bytes. If such bytes have not been placed in the same chunk (CHUNKSIZE=1024), function 'is_text_file' from encoding.py will fail on this input.
Solution is to use IncrementadDecoder.
It is possible that issue #2703 is related to this fix. Since the file attached to issue is determined as binary, spyder tries to open it with external program (console) (instead of editing)