Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added .idea folder to .gitignore for PyCharm users #2890

Merged
merged 1 commit into from
Jan 4, 2016

Conversation

dhirschfeld
Copy link
Contributor

No description provided.

@Nodd
Copy link
Contributor

Nodd commented Jan 1, 2016

That's not very informative. Do you at least have a link explaining why it's useful ?

@cjrh
Copy link
Contributor

cjrh commented Jan 2, 2016

The PyCharm IDE uses a hidden folder .idea/ to keep "project information and settings" for the IDE. If .idea/ is not added to .gitignore, you keep getting asked whether you want to add things like vcs.xml to version control. This is one of the files within the .idea/ folder. I'm personally neutral on this PR, even though I've started using PyCharm, but that's the basic background.

@dhirschfeld
Copy link
Contributor Author

As @cjrh mentions it's the folder reserved for PyCharm specific settings so shouldn't be committed to the repo.

This PR simply adds that folder to the .gitignore file which improves the development experience for PyCharm users hence lowering the barrier to contribution (in an admittedly small way).

@Nodd
Copy link
Contributor

Nodd commented Jan 3, 2016

Oh sorry, I thought that it was an issue instead of a pr. I'm fine with it then.

@ccordoba12 ccordoba12 added this to the V3.0beta3 milestone Jan 4, 2016
@ccordoba12
Copy link
Member

I'm fine with this. No problem with our contributors using other IDEs to develop Spyder, though I'd prefer them to use Spyder itself to do it ;-)

@ccordoba12 ccordoba12 changed the title Added .idea folder to .gitignore for PyCharm users Added .idea folder to .gitignore for PyCharm users Jan 4, 2016
ccordoba12 added a commit that referenced this pull request Jan 4, 2016
Added .idea folder to .gitignore for PyCharm users
@ccordoba12 ccordoba12 merged commit b0e8539 into spyder-ide:master Jan 4, 2016
@cjrh
Copy link
Contributor

cjrh commented Jan 4, 2016

@ccordoba12 Think of it as "IDE bootstrapping" 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants