PR: Crashing on shortcut assignment with PyQt5 #2881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix crash on shortcut assignment (Qt5 'dataChanged' signal has 3 parameters)
| self.table.proxy_model.dataChanged.connect( | ||
| lambda i1, i2, opt='': self.has_been_modified(opt)) | ||
| lambda i1, i2, roles=[], opt='': self.has_been_modified(opt)) | ||
| self.reset_btn.clicked.connect(self.reset_to_default) |
There was a problem hiding this comment.
Hi @Qlogin, thanks for working on this.
I think that to make the code much clearer to future contributors we could check the current API in use and then feed the correct connection
Like
from spyderlib.qt import PYQT5
...
if PYQT5:
# Qt5 'dataChanged' has 3 parameters
self.table.proxy_model.dataChanged.connect(lambda i1, i2, roles=[], opt='': self.has_been_modified(opt))
else:
self.table.proxy_model.dataChanged.connect(lambda i1, i2, opt='': self.has_been_modified(opt))
|
I agree with @goanpeca too. |
|
@Qlogin any updates? |
check the current API in use and then feed the correct connection
|
Sorry. Problems with e-mail notifications. |
|
Neat!, thanks, this is good to go, right @ccordoba12 ? |
goanpeca
changed the title
|
@Qlogin, thanks a lot for your contribution and sorry for the big delay in merging :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix crash on shortcut assignment (Qt5 'dataChanged' signal has 3 parameters)