Restore the insertion of the "(" character when parameter close_parentheses_enabled is False #2810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Restore the insertion of the "(" character when parameter close_parentheses_enabled is False.
I suspect some patch destroyed the functionnality formerly in handle_close_parentheses(text)
This is the simple fix, maybe a more complete fix would remove unused path in def handle_close_parentheses()
ccordoba12
added
type:Enhancement
component:Editor
type:Bug
and removed
type:Enhancement
labels
ccordoba12
changed the title
|
Thanks for the fix, I also think it's the right one :-) |
ccordoba12
added a commit
that referenced
this pull request
Nov 26, 2015
Restore the insertion of the "(" character when parameter close_parentheses_enabled is False
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2795
Restore the insertion of the "(" character when parameter close_parentheses_enabled is False.
I suspect some patch destroyed the functionnality formerly in handle_close_parentheses(text)
This is the simple fix, maybe a more complete fix would remove unused path in def handle_close_parentheses()