Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the spyder script to the right place if it isn't present in the site Scripts directory #2786

Merged
merged 1 commit into from
Nov 5, 2015

Conversation

lpinner
Copy link
Contributor

@lpinner lpinner commented Oct 30, 2015

The post install script assumes the spyder script is in the site scripts directory, but it isn't always installed there, i.e if spyder was installed using pip install --user spyder

If the user then runs spyder_win_post_install.py -install manually, the shortcuts will be created pointing to a non-existent script.

… installed using ```pip install --user spyder```
@Nodd
Copy link
Contributor

Nodd commented Oct 30, 2015

It looks like your line could be always used, even if spyder is in sys.prefix + '/scripts'. The code would be simpler.
(Also the failure seems unrelated to your modification)

@ccordoba12
Copy link
Member

Yes, sorry about the failure. I'm seeing how to fix it :-)

@ccordoba12 ccordoba12 added this to the v3.0 milestone Oct 30, 2015
@ccordoba12
Copy link
Member

Thanks a lot for your contribution. It seems the right fix, so I'm merging it ;-)

@ccordoba12 ccordoba12 changed the title The spyder script isn't always in the site scripts directory Move the spyder script to the right place if it isn't present in the Scripts directory Nov 5, 2015
@ccordoba12 ccordoba12 changed the title Move the spyder script to the right place if it isn't present in the Scripts directory Move the spyder script to the right place if it isn't present in the site Scripts directory Nov 5, 2015
ccordoba12 added a commit that referenced this pull request Nov 5, 2015
Move the spyder script to the right place if it isn't present in the site Scripts directory
@ccordoba12 ccordoba12 merged commit 10881f8 into spyder-ide:master Nov 5, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants