-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tab completions for PathCombobox #2692
Merged
ccordoba12
merged 10 commits into
spyder-ide:master
from
goanpeca:feature/global-autocomplete
Nov 16, 2015
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
6e4351f
Add completion for PathCombobox (Global Working dir and find files)
goanpeca 048e751
Remove tab!
goanpeca 70e2210
Adapt completion behavior to resemble bash completion
goanpeca acfac95
Update PathCombobox behavior and style, update pep8 and perform fixes…
goanpeca 270b8d3
Remove comments
goanpeca ed87382
Move to helper widgets, fix typo, refactor code
goanpeca 26aeb9f
Fix cpu over use
goanpeca 2a8bada
Fix combobox refresh on style change
goanpeca bb6ff77
Hide status icon on focus out.
goanpeca e69220a
Move PathComboBox status icon to the right.
goanpeca File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove blanks only if they're around the code you're touching. This is not a problem in this case because we almost never touch
comboboxes
, so it's not a blocker for merging :-)But I've had major headaches trying to merge things between 2.3 and master when that rule is not followed :-)
My idea is to (slowly) move to remove blanks and adhere to pep8, by following Raymond Hettinger advice: https://www.youtube.com/watch?v=wf-BqAjZb8M
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, I have seen that video more than once ;-)