Change plugins directory to spyplugins and make it a namespace package #2565

goanpeca · 2015-07-27T20:18:05Z

This works builds on top of the work made by @Nodd (dont worry, your commits are all there ;-) )

~~I still have an issue when running the translation scripts~~

Todo

Change plugins folder from spyderplugins to spyplugins/ui
Change plugins folder from spyderplugins to spyplugins/io
Fix translations
Remove p_ prefix from plugins
Fix image display in preferences for plugins (pylint and profiler)

goanpeca · 2015-07-27T20:19:33Z

@ccordoba12 when running python gettext_scan I am getting this:

Updating... spyderlib/locale/fr/LC_MESSAGES/spyderlib.po
merge...
spyderlib/locale/spyderlib.pot:2690: duplicate message definition...
spyderlib/locale/spyderlib.pot:6: ...this is the location of the first definition
msgmerge: found 1 fatal error
Updating... spyderlib/locale/es/LC_MESSAGES/spyderlib.po
merge...
spyderlib/locale/spyderlib.pot:2690: duplicate message definition...
spyderlib/locale/spyderlib.pot:6: ...this is the location of the first definition
msgmerge: found 1 fatal error
Updating... spyderlib/locale/pt_BR/LC_MESSAGES/spyderlib.po
merge...
spyderlib/locale/spyderlib.pot:2690: duplicate message definition...
spyderlib/locale/spyderlib.pot:6: ...this is the location of the first definition
msgmerge: found 1 fatal error

ccordoba12 · 2015-07-27T21:04:50Z

No idea, I'll check this out after beta1

goanpeca · 2015-07-31T23:49:04Z

@ccordoba12 ... ok this was a bit longer than expected but I think it is now working. I need some testers...

ccordoba12 · 2015-08-01T00:50:10Z

I'll test this weekend :-)

goanpeca · 2015-08-01T05:39:18Z

@SylvainCorlay how should we handle icons in external plugins? I mean, we need to define some sane/easy way for people to define both a fontawesome icon and a normal image icon...

ccordoba12 · 2015-08-08T21:40:31Z

This needs a rebase too.

Also, I'm getting this traceback in Python 3 (Python 2 works just fine ;-):

ERROR: 3rd party plugin import failed for `spyplugins.io.hdf5`
Traceback (most recent call last):
  File "/home/carlos/Projects/spyder/github-repo/spyderlib/otherplugins.py", line 53, in _import_plugin
    submodule = imp.load_module(submodule_name, *info)
  File "/home/carlos/.virtualenvs/test-ipy3-stable/lib/python3.4/imp.py", line 235, in load_module
    return load_source(name, filename, file)
  File "/home/carlos/.virtualenvs/test-ipy3-stable/lib/python3.4/imp.py", line 171, in load_source
    module = methods.load()
  File "<frozen importlib._bootstrap>", line 1220, in load
  File "<frozen importlib._bootstrap>", line 1200, in _load_unlocked
  File "<frozen importlib._bootstrap>", line 1129, in _exec
  File "<frozen importlib._bootstrap>", line 1444, in exec_module
  File "<frozen importlib._bootstrap>", line 1554, in get_code
  File "<frozen importlib._bootstrap>", line 672, in _code_to_bytecode
ValueError: unmarshallable object
ERROR: 3rd party plugin import failed for `spyplugins.io.dicom`
Traceback (most recent call last):
  File "/home/carlos/Projects/spyder/github-repo/spyderlib/otherplugins.py", line 53, in _import_plugin
    submodule = imp.load_module(submodule_name, *info)
  File "/home/carlos/.virtualenvs/test-ipy3-stable/lib/python3.4/imp.py", line 235, in load_module
    return load_source(name, filename, file)
  File "/home/carlos/.virtualenvs/test-ipy3-stable/lib/python3.4/imp.py", line 171, in load_source
    module = methods.load()
  File "<frozen importlib._bootstrap>", line 1220, in load
  File "<frozen importlib._bootstrap>", line 1200, in _load_unlocked
  File "<frozen importlib._bootstrap>", line 1129, in _exec
  File "<frozen importlib._bootstrap>", line 1444, in exec_module
  File "<frozen importlib._bootstrap>", line 1554, in get_code
  File "<frozen importlib._bootstrap>", line 672, in _code_to_bytecode
ValueError: unmarshallable object
ERROR: 3rd party plugin import failed for `spyplugins.io.hdf5`
Traceback (most recent call last):
  File "/home/carlos/Projects/spyder/github-repo/spyderlib/otherplugins.py", line 53, in _import_plugin
    submodule = imp.load_module(submodule_name, *info)
  File "/home/carlos/.virtualenvs/test-ipy3-stable/lib/python3.4/imp.py", line 235, in load_module
    return load_source(name, filename, file)
  File "/home/carlos/.virtualenvs/test-ipy3-stable/lib/python3.4/imp.py", line 171, in load_source
    module = methods.load()
  File "<frozen importlib._bootstrap>", line 1220, in load
  File "<frozen importlib._bootstrap>", line 1200, in _load_unlocked
  File "<frozen importlib._bootstrap>", line 1129, in _exec
  File "<frozen importlib._bootstrap>", line 1444, in exec_module
  File "<frozen importlib._bootstrap>", line 1554, in get_code
  File "<frozen importlib._bootstrap>", line 672, in _code_to_bytecode
ValueError: unmarshallable object
ERROR: 3rd party plugin import failed for `spyplugins.io.dicom`
Traceback (most recent call last):
  File "/home/carlos/Projects/spyder/github-repo/spyderlib/otherplugins.py", line 53, in _import_plugin
    submodule = imp.load_module(submodule_name, *info)
  File "/home/carlos/.virtualenvs/test-ipy3-stable/lib/python3.4/imp.py", line 235, in load_module
    return load_source(name, filename, file)
  File "/home/carlos/.virtualenvs/test-ipy3-stable/lib/python3.4/imp.py", line 171, in load_source
    module = methods.load()
  File "<frozen importlib._bootstrap>", line 1220, in load
  File "<frozen importlib._bootstrap>", line 1200, in _load_unlocked
  File "<frozen importlib._bootstrap>", line 1129, in _exec
  File "<frozen importlib._bootstrap>", line 1444, in exec_module
  File "<frozen importlib._bootstrap>", line 1554, in get_code
  File "<frozen importlib._bootstrap>", line 672, in _code_to_bytecode
ValueError: unmarshallable object

This is printed in both the internal console and also the terminal from which Spyder was started.

@goanpeca, can you reproduce it?

goanpeca · 2015-08-16T16:22:08Z

@ccordoba12 will try to work on this tomorrow

goanpeca · 2015-08-30T05:38:05Z

@ccordoba12 so I think this one is fixed now and should be working on Py2.7 3.3 and 3.4

Can you test it ?

goanpeca · 2015-08-30T07:28:38Z

@ccordoba12 this will not work unless we use setuptools.... distutils cannot handle namespace packages...

goanpeca · 2015-08-30T20:51:34Z

@ccordoba12 now it is ready, can you test?

ccordoba12 · 2015-08-30T22:46:28Z

setup.py

-                    'spyderplugins':
-                    get_package_data('spyderplugins', EXTLIST)},
+                    'spyplugins':
+                    get_package_data('spyplugins', EXTLIST+['.py']),


Isn't .py part of EXTLIST?

Another thing: doesn't get_package_data works recursively? It would seem like that given that before it was only necessary to pass spyderplugins to it :-)

Probably :-)

Ok, please check that out before merging

ccordoba12 · 2015-08-30T23:27:08Z

Ok, first review done. It's working without errors on Python 3, but I still have to:

Test this on Windows.
Run pylint and profiler with example files to see if they are working as before :-)

Thanks a lot for this @goanpeca and @Nodd. It seems a lot of work, I mean, from the design and implementation point of view.

goanpeca · 2015-09-01T16:14:38Z

@ccordoba12 I organized the code a bit better and addressed your questions.

ccordoba12 · 2015-09-03T12:45:24Z

Ok, thanks. I'll give another review later today, and also test this on Windows.

goanpeca · 2015-09-13T14:49:53Z

@ccordoba12 have you had time to review and test this?

ccordoba12 · 2015-11-16T22:20:33Z

Ok, it seems the time has come (finally!) to press the green button on this one :-)

Thanks a lot @Nodd and @goanpeca for your work. It's a really great improvement!

Change plugins directory to spyplugins and make it a namespace package

goanpeca · 2015-11-16T22:26:04Z

👍, now I will push the plugin manager PR :-)

goanpeca · 2015-11-16T22:26:26Z

Side note: conda-manager plugin is a bit broken right now....

ccordoba12 · 2015-11-16T22:33:42Z

Ok, no biggie. There are the other plugins to test :-)

Nodd · 2015-11-17T00:37:52Z

Cool, thanks to @goanpeca for finishing the work and @ccordoba12 for the review !

goanpeca added this to the v3.0 milestone Jul 27, 2015

goanpeca self-assigned this Jul 27, 2015

goanpeca changed the title ~~Change Plugin directories to spyderuiplugins~~ Change Plugin directories to spyplugins/ui and spyplugins/io Jul 31, 2015

ccordoba12 mentioned this pull request Aug 3, 2015

Load spyderplugins from directories #2362

Closed

5 tasks

goanpeca changed the title ~~Change Plugin directories to spyplugins/ui and spyplugins/io~~ [WIP] Change Plugin directories to spyplugins/ui and spyplugins/io Aug 16, 2015

goanpeca changed the title ~~[WIP] Change Plugin directories to spyplugins/ui and spyplugins/io~~ Change Plugin directories to spyplugins/ui and spyplugins/io Aug 30, 2015

ccordoba12 reviewed Aug 30, 2015
View reviewed changes

ccordoba12 added the type:Techdebt label Aug 30, 2015

Nodd and others added 23 commits November 16, 2015 16:58

path is now Path

caa5c44

Fix setup.py for ioplugins

880412a

Rename 'spyderplugins' namespace to 'spyderuiplugins'

d082393

Change spyderplugins to spyplugins/ui and spyplugins/io

220ee58

Fix python 33 and 34 plugins compatibility

58ae57f

rebase

4fbf976

Fix icon loadijng for third party plugins

6fb9f28

Fix example plugin icons

50ba8d2

Add icons for autopep8

511c4db

Remove redundant info in setup.py

76774e8

Update check and write of user plugins folder structure, add comments

bfceea0

Make io plugins search similar to ui plugins

7ddda8d

Remove unneded variable

5ca6390

Update plugins icon names and add copyright

5ca1153

Revert to os.path use, instead of Path

4237c1e

Restructure io plugins

9cf2f9b

Remove unwanted tabs

a45edb2

Remove Path

e0f921e

Restore IMAGE_PATH and remove Path

0c8cfd8

Update setup.py to correctly build wheel

8c545e6

Remove test for plugins

037e6c7

Add try except to spyplugins widgets to enable testing

ebefff1

Minor comment/style fixes

c8035ba

ccordoba12 added a commit that referenced this pull request Nov 16, 2015

Merge pull request #2565 from goanpeca/plugin_directories

fdd86f5

Change plugins directory to spyplugins and make it a namespace package

ccordoba12 merged commit fdd86f5 into spyder-ide:master Nov 16, 2015

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Change plugins directory to spyplugins and make it a namespace package #2565

Change plugins directory to spyplugins and make it a namespace package #2565

goanpeca commented Jul 27, 2015

goanpeca commented Jul 27, 2015

ccordoba12 commented Jul 27, 2015

goanpeca commented Jul 31, 2015

ccordoba12 commented Aug 1, 2015

goanpeca commented Aug 1, 2015

ccordoba12 commented Aug 8, 2015

goanpeca commented Aug 16, 2015

goanpeca commented Aug 30, 2015

goanpeca commented Aug 30, 2015

goanpeca commented Aug 30, 2015

ccordoba12 Aug 30, 2015

ccordoba12 Aug 30, 2015

goanpeca Aug 30, 2015

ccordoba12 Aug 30, 2015

ccordoba12 commented Aug 30, 2015

goanpeca commented Sep 1, 2015

ccordoba12 commented Sep 3, 2015

goanpeca commented Sep 13, 2015

ccordoba12 commented Nov 16, 2015

goanpeca commented Nov 16, 2015

goanpeca commented Nov 16, 2015

ccordoba12 commented Nov 16, 2015

Nodd commented Nov 17, 2015

Change plugins directory to spyplugins and make it a namespace package #2565

Change plugins directory to spyplugins and make it a namespace package #2565

Conversation

goanpeca commented Jul 27, 2015

Todo

goanpeca commented Jul 27, 2015

ccordoba12 commented Jul 27, 2015

goanpeca commented Jul 31, 2015

ccordoba12 commented Aug 1, 2015

goanpeca commented Aug 1, 2015

ccordoba12 commented Aug 8, 2015

goanpeca commented Aug 16, 2015

goanpeca commented Aug 30, 2015

goanpeca commented Aug 30, 2015

goanpeca commented Aug 30, 2015

ccordoba12 Aug 30, 2015

Choose a reason for hiding this comment

ccordoba12 Aug 30, 2015

Choose a reason for hiding this comment

goanpeca Aug 30, 2015

Choose a reason for hiding this comment

ccordoba12 Aug 30, 2015

Choose a reason for hiding this comment

ccordoba12 commented Aug 30, 2015

goanpeca commented Sep 1, 2015

ccordoba12 commented Sep 3, 2015

goanpeca commented Sep 13, 2015

ccordoba12 commented Nov 16, 2015

goanpeca commented Nov 16, 2015

goanpeca commented Nov 16, 2015

ccordoba12 commented Nov 16, 2015

Nodd commented Nov 17, 2015