Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make completions scroll to top of list #2322

Merged
merged 1 commit into from
Apr 16, 2015

Conversation

blink1073
Copy link
Contributor

Fixes #1876.

screen shot 2015-04-12 at 9 09 07 pm

@goanpeca
Copy link
Member

Love this 👍

@ccordoba12
Copy link
Member

This is really cool!! Thanks @blink1073!!

Could we also narrow down the completion list to only show those items that match the completion text?

@goanpeca
Copy link
Member

How easy/hard would it be to make the code completion more attractive (like pycharm)... would it be too much work to have an icon for private methods... constants.. classes... methods, special python methods (__init__etc..)??

@ccordoba12
Copy link
Member

That info is provided by Jedi (Unfortunately, I don't know if by Rope too). Maybe @blink1073 could submit a new PR implementing that too? ;-)

@goanpeca
Copy link
Member

Please @blink1073, it would be something more aesthetic but would make the completion look so much better!!!

@blink1073
Copy link
Contributor Author

@ccordoba12, counter proposal: what if I implemented fuzzy logic and only show the completions from the original list that contain the entered characters?

A quick look shows that we can access this from the rope completion proposals. Completions could be returned as (completion, type) tuples with associated icons. I don't mind implementing the logic, but I do not want to get into the icon business. I'll start another issue for discussion on that.

@ccordoba12
Copy link
Member

@ccordoba12, counter proposal: what if I implemented fuzzy logic and only show the completions from the original list that contain the entered characters?

I don't like fuzzy logic that much, but it could be cool to have it.

But let's leave it for another PR. This one is simple enough and solves precisely what it wants to accomplish.

ccordoba12 added a commit that referenced this pull request Apr 16, 2015
Make completions scroll to top of list
@ccordoba12 ccordoba12 merged commit 7d84281 into spyder-ide:master Apr 16, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Editor: Move suggested completion item to top of window
3 participants