Replace obsolete setTextColor method by setForeground in qtreewidgetitem

[dhoegh]

Fixes #2305

---

@Nodd could you check if this fixes your problem?

[ccordoba12]

@Nodd, could you test @dhoegh fix please?

[goanpeca]

@Nodd ?

[goanpeca]

@dhoegh can we have a more explanatory title for this PR?

[Nodd]

Now I have

Traceback (most recent call last):
  File "/home/joseph/prog/spyder.git/spyderplugins/widgets/profilergui.py", line 253, in <lambda>
    self.finished(ec, es))
  File "/home/joseph/prog/spyder.git/spyderplugins/widgets/profilergui.py", line 318, in finished
    self.show_data(justanalyzed=True)
  File "/home/joseph/prog/spyder.git/spyderplugins/widgets/profilergui.py", line 340, in show_data
    self.datatree.show_tree()
  File "/home/joseph/prog/spyder.git/spyderplugins/widgets/profilergui.py", line 467, in show_tree
    self.populate_tree(self, self.find_callees(rootkey))
  File "/home/joseph/prog/spyder.git/spyderplugins/widgets/profilergui.py", line 540, in populate_tree
    child_item.setTextColor(2, QColor(cum_time_dif[1]))
AttributeError: 'TreeWidgetItem' object has no attribute 'setTextColor'

And the name and total time of the first function appear in the table, so it's already better !

[dhoegh]

@Nodd thank you for testing, I will debug further in the weekend when I have some time off from the master thesis.

[dhoegh]

@nood I am not able to reproduce your result on ubuntu 14.10 Python 2.7.8 64bits, Qt 4.8.6, PyQt4 (API v2) 4.11.2 on Linux do you have any idea what could be wrong?

[dhoegh]

Everything seems to work fine on my side with this pr's branch, but on master I am able to reproduce you error reported in #2305

>>> Traceback (most recent call last):
  File "/media/hoegh/8CA055F2A055E2EE/Users/Hoegh/Documents/spyder/spyderplugins/widgets/profilergui.py", line 253, in <lambda>
    self.finished(ec, es))
  File "/media/hoegh/8CA055F2A055E2EE/Users/Hoegh/Documents/spyder/spyderplugins/widgets/profilergui.py", line 318, in finished
    self.show_data(justanalyzed=True)
  File "/media/hoegh/8CA055F2A055E2EE/Users/Hoegh/Documents/spyder/spyderplugins/widgets/profilergui.py", line 339, in show_data
    self.datatree.load_data(self.DATAPATH)
  File "/media/hoegh/8CA055F2A055E2EE/Users/Hoegh/Documents/spyder/spyderplugins/widgets/profilergui.py", line 427, in load_data
    map(lambda x: x.calc_callees().stats, stats_indi)
  File "/media/hoegh/8CA055F2A055E2EE/Users/Hoegh/Documents/spyder/spyderplugins/widgets/profilergui.py", line 427, in <lambda>
    map(lambda x: x.calc_callees().stats, stats_indi)
AttributeError: 'NoneType' object has no attribute 'stats'

[dhoegh]

@goanpeca could you see if you can find any problems with the profiler on this branch, because I can't reproduce what @Nodd sees on either linux/windows with 2.7 or 3.4.

[goanpeca]

@dhoegh sorry for the delay, I tested your branch on win7 py2.7 and py3.4 and it seems to be working fine 👍

[Nodd]

Aha, setTextColor is obsolete: http://doc.qt.io/qt-4.8/qtreewidgetitem-obsolete.html
Since I use Qt5, it was removed but it is still present in Qt4.8 to keep compatibility.

[dhoegh]

@Nodd I have pushed a new commit where setTextColor is changed to setForeground. Can you verify this solves your problem with the profiler completely?

[Nodd]

It works, thanks !

[goanpeca]

Merging then?

[dhoegh]

Great, then this is good to merge:)

[goanpeca]

Thanks for working on this @dhoegh.

---

@ccordoba12, this should be ready for merging

[ccordoba12]

@Nodd, thanks a lot for the review and for testing ;-)