-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace obsolete setTextColor method by setForeground in qtreewidgetitem #2309
Conversation
@Nodd ? |
@dhoegh can we have a more explanatory title for this PR? |
Now I have
And the name and total time of the first function appear in the table, so it's already better ! |
@Nodd thank you for testing, I will debug further in the weekend when I have some time off from the master thesis. |
@nood I am not able to reproduce your result on ubuntu 14.10 |
Everything seems to work fine on my side with this pr's branch, but on master I am able to reproduce you error reported in #2305
|
@dhoegh sorry for the delay, I tested your branch on win7 py2.7 and py3.4 and it seems to be working fine 👍 |
Aha, |
…ed and is not present in Qt5.
@Nodd I have pushed a new commit where |
It works, thanks ! |
Merging then? |
Great, then this is good to merge:) |
Thanks for working on this @dhoegh. @ccordoba12, this should be ready for merging |
@Nodd, thanks a lot for the review and for testing ;-) |
Replace obsolete setTextColor method by setForeground in qtreewidgetitem
Fixes #2305
@Nodd could you check if this fixes your problem?