-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR: Handle case when kernel fault file doesn't exist and show error with info explaining that no connection was possible (IPython Console) #22628
Conversation
… show error with info explainig no connection was possible
A couple of questions for @dalthviz:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On second thought, I think this is fine for a bugfix release @dalthviz.
I'm only leaving you a suggestion for the text you added.
Co-authored-by: Carlos Cordoba <ccordoba12@gmail.com>
From what I tested it seems like yes 👍
Make sense but I would say that involves adding new logic and sounds more like an enhancement than a bug fix alone. Following your last comment, should an issue be created to track that enhancement idea (validation logic + feedback icon when selecting a kernel connection file)? |
Yeah, I think that's a good idea. Please create one so that we don't forget to address that later. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @dalthviz!
@meeseeksdev please backport to 6.x |
…doesn't exist and show error with info explaining that no connection was possible (IPython Console)
…ile doesn't exist and show error with info explaining that no connection was possible (IPython Console)) (#22694)
Description of Changes
Seems like passing a
.json
file that doesn't correspond to a kernel connection file (like for example a.json
that corresponds to a notebook server instance connection file) can cause the kernel fault file to not be initialized causing and error when trying to compute a message to show to the user. Also, add an error message to prevent keep showing theConnecting to kernel
over the console infowidget when no connection was possible.A preview:
Issue(s) Resolved
Fixes #22448
Affirmation
By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.
I certify the above statement is true and correct: dalthviz