Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Don't kill kernel process tree when running in Binder (IPython console) #22509

Merged
merged 3 commits into from
Sep 15, 2024

Conversation

ccordoba12
Copy link
Member

@ccordoba12 ccordoba12 commented Sep 15, 2024

Description of Changes

  • This fixes a hard freeze when kernels are killed or restarted there.
  • Also, fix Binder links and replace Quansight logo by CZI one in our Readme

Issue(s) Resolved

Fixes #22124

Affirmation

By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct: @ccordoba12

Unfortunately, Spyder freezes while doing that there.
@ccordoba12
Copy link
Member Author

/show binder

Copy link

Binder 👈 Launch a Binder instance on this branch

@ccordoba12 ccordoba12 force-pushed the issue-22124 branch 4 times, most recently from dfde055 to dbd2c76 Compare September 15, 2024 21:03
@ccordoba12 ccordoba12 merged commit 4928641 into spyder-ide:master Sep 15, 2024
24 checks passed
@ccordoba12 ccordoba12 deleted the issue-22124 branch September 15, 2024 22:06
@ccordoba12
Copy link
Member Author

@meeseeksdev please backport to 6.x

meeseeksmachine pushed a commit to meeseeksmachine/spyder that referenced this pull request Sep 15, 2024
ccordoba12 added a commit that referenced this pull request Sep 16, 2024
…when running in Binder (IPython console)) (#22510)

Co-authored-by: Carlos Cordoba <ccordoba12@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Spyder on Binder is non-responsive
1 participant