Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Update contributing, release and maintenance instructions for backporting #22442

Merged

Conversation

ccordoba12
Copy link
Member

@ccordoba12 ccordoba12 commented Sep 6, 2024

Description of Changes

This not only simplifies our workflow by avoiding the need to manually forward-port PRs from the stable branch to master. It'll also help us to maintain a more stable branch, by only backporting what we think is really necessary.

Issue(s) Resolved

Fixes #

Affirmation

By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct: @ccordoba12

@ccordoba12 ccordoba12 added this to the v6.0.1 milestone Sep 6, 2024
@ccordoba12 ccordoba12 self-assigned this Sep 6, 2024
@ccordoba12 ccordoba12 force-pushed the update-instructions-for-backporting branch from c60f43c to 1668b38 Compare September 7, 2024 15:53
@ccordoba12
Copy link
Member Author

@dalthviz, this is ready for review.

RELEASE.md Outdated Show resolved Hide resolved
@dalthviz
Copy link
Member

dalthviz commented Sep 7, 2024

Give a quick check and makes sense to me 👍 Left only a single comment related with the management of the alpha part over the version update. Also, thinking about docs updates. Could this PR be a good place to update the README badges that launch binder instances?

image

Not sure if there are other places where 5.x is still being mentioned 🤔

Also, update instructions to release stable versions.
With backporting is not easy to count the commits between two tags, so
we can't report them anymore.
@ccordoba12 ccordoba12 force-pushed the update-instructions-for-backporting branch from 1668b38 to c7da849 Compare September 15, 2024 17:50
@ccordoba12
Copy link
Member Author

Could this PR be a good place to update the README badges that launch binder instances?

I'll leave that for another PR to include a critical fix to avoid hard freezes on Binder.

Copy link
Member

@dalthviz dalthviz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ccordoba12 ! LGTM 👍 Following the updated steps, after this gets merged, this should be backported to 6.x, right?

Also, is there any other change you want to add here or should I proceed with the merge?

@ccordoba12
Copy link
Member Author

Following the updated steps, after this gets merged, this should be backported to 6.x, right?

Correct. If a PR is marked for 6.0.x, 6.1.x, etc, it needs to be backported.

Also, is there any other change you want to add here or should I proceed with the merge?

Nop, this is ready.

By the way, I'm using regular merges in master to preserve the commit history, but squash merges in 6.x because history is not so critical there. And I'm planning to add another bot to automatically do that in 6.x.

@dalthviz dalthviz merged commit 2a9515b into spyder-ide:master Sep 16, 2024
@dalthviz
Copy link
Member

@meeseeksdev please backport to 6.x

@dalthviz
Copy link
Member

By the way, I'm using regular merges in master to preserve the commit history, but squash merges in 6.x because history is not so critical there. And I'm planning to add another bot to automatically do that in 6.x.

Is there a case where you will need to merge something directly to 6.x without passing from master and the backporting procedure (which seems like creates a PR with a single commit)?

dalthviz added a commit that referenced this pull request Sep 16, 2024
…442-on-6.x

Backport PR #22442 on branch 6.x (PR: Update contributing, release and maintenance instructions for backporting)
@ccordoba12 ccordoba12 deleted the update-instructions-for-backporting branch September 17, 2024 15:54
@ccordoba12
Copy link
Member Author

Is there a case where you will need to merge something directly to 6.x without passing from master and the backporting procedure (which seems like creates a PR with a single commit)?

There should be very few things that only apply to 6.x. For instance, I made PR #22468 to fix its dev version because that couldn't be backported (PR #22465 was the equivalent for master).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants