-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR: Prioritize conda-forge channel so that stable releases are pulled above unstable ones (Installers) #22424
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks @mrclary!
Could it be worthy to also add a CI step that checks that the |
This is probably a good idea. It will require more work in order to expose the expected version. Let me know if you'd like me to include that in this PR. |
I think makes sense adding that here, however what do you think @ccordoba12 ? |
Yeah, I think we can include it here. |
c695d07
to
ea891d5
Compare
Okay, the test step now verifies that the installed Spyder version is the expected version. |
17563f8
to
a003501
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @mrclary ! LGTM 👍
Just in case, is there any other thing pending here or should I proceed with the merge?
Nothing else pending. Thanks @dalthviz. |
@meeseeksdev please backport to 6.x |
…hat stable releases are pulled above unstable ones (Installers)
…424-on-6.x Backport PR #22424 on branch 6.x (PR: Prioritize conda-forge channel so that stable releases are pulled above unstable ones (Installers))
Description of Changes
Release of 6.0.0 revealed an issue where the conda solver would take
6.0.0rc2
as satisfying the specification6.0.0
. I did not realize that6.0.0
lacked the specificity required to distinguish it from6.0.0rc2
, but not the other way around.By setting the
conda-forge
channel first, it will take priority overlabel/spyder_dev
and take the6.0.0
package first. On developer and release candidate builds, the version specificity, e.g.6.0.1.dev0
or6.0.1rc1
, will ensure that stable versions are overlooked in the higher priorityconda-forge
channel and the specified version will be obtained from the appropriate channel.Fixes #22416