PR: Prioritize conda-forge channel so that stable releases are pulled above unstable ones (Installers) #22424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccordoba12
approved these changes
Sep 5, 2024
ccordoba12
changed the title
|
Could it be worthy to also add a CI step that checks that the |
This is probably a good idea. It will require more work in order to expose the expected version. Let me know if you'd like me to include that in this PR. |
|
I think makes sense adding that here, however what do you think @ccordoba12 ? |
|
Yeah, I think we can include it here. |
mrclary
force-pushed
the
6.0.0_1
branch
2 times, most recently
from
c695d07
to
ea891d5
Compare
|
Okay, the test step now verifies that the installed Spyder version is the expected version. |
mrclary
force-pushed
the
6.0.0_1
branch
2 times, most recently
from
17563f8
to
a003501
Compare
|
Nothing else pending. Thanks @dalthviz. |
|
@meeseeksdev please backport to 6.x |
meeseeksmachine
pushed a commit
to meeseeksmachine/spyder
that referenced
this pull request
Sep 17, 2024
…hat stable releases are pulled above unstable ones (Installers)
dalthviz
added a commit
that referenced
this pull request
Sep 17, 2024
…424-on-6.x Backport PR #22424 on branch 6.x (PR: Prioritize conda-forge channel so that stable releases are pulled above unstable ones (Installers))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Release of 6.0.0 revealed an issue where the conda solver would take
6.0.0rc2as satisfying the specification6.0.0. I did not realize that6.0.0lacked the specificity required to distinguish it from6.0.0rc2, but not the other way around.By setting the
conda-forgechannel first, it will take priority overlabel/spyder_devand take the6.0.0package first. On developer and release candidate builds, the version specificity, e.g.6.0.1.dev0or6.0.1rc1, will ensure that stable versions are overlooked in the higher priorityconda-forgechannel and the specified version will be obtained from the appropriate channel.Fixes #22416