PR: Update connections dialog size constants, title and icon (Remote Client) #22303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dalthviz
force-pushed
the
fixes_issue_22225_p1
branch
from
72bacf0
to
c2b3490
Compare
dalthviz
changed the title
|
Thanks for your work on this @dalthviz! The only problem I see with your changes is that we'd end up with too much padding for the contents of the connection pages in the dialog. For consistency, we should have the same padding in this dialog as the one we have in the Preferences one. |
|
/show binder |
|
|
ccordoba12
approved these changes
Aug 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Change connections dialog sizes constraints to prevent weird resize causing content to not be visible. Also change dialog title and icon:
Issue(s) Resolved
Part of #22225
Affirmation
By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.
I certify the above statement is true and correct: dalthviz