Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Add ability to show plots for dataframes (Variable Explorer) #21969

Merged
merged 8 commits into from
May 10, 2024

Conversation

dpturibio
Copy link
Contributor

Description of Changes

  • Wrote at least one-line docstrings (for any new functions)
  • Added unit test(s) covering the changes (if testable)
  • Included a screenshot or animation (if affecting the UI, see Licecap)

Enables "plot" item for dataframes following the same structure of code used for plotting arrays, that redirects the plot to IPython console at the end, using %varexp --plot [variable_name]

Issue(s) Resolved

Fixes #21743

Affirmation

By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct: @dpturibio

@pep8speaks
Copy link

pep8speaks commented Apr 5, 2024

Hello @dpturibio! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2024-04-23 01:05:33 UTC

@ccordoba12 ccordoba12 changed the title activate plot option for dataframes PR: Add plot button to dataframe editor (Variable Explorer) Apr 8, 2024
@ccordoba12 ccordoba12 changed the title PR: Add plot button to dataframe editor (Variable Explorer) PR: Add ability to show plots for dataframes (Variable Explorer) Apr 8, 2024
@ccordoba12 ccordoba12 added this to the v6.0beta1 milestone Apr 8, 2024
@ccordoba12
Copy link
Member

Hey @dpturibio, thanks for your work on this! For now, please rebase on top of or merge with our latest master to get the fixes we did last week to our tests.

@dpturibio
Copy link
Contributor Author

Thank you @ccordoba12.
I was wondering why so many tests were failing, and that's why...

@dpturibio
Copy link
Contributor Author

@ccordoba12 let me know if code is ok to merge

Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution @dpturibio! I left two small suggestions for you, the rest looks good to me.

spyder/widgets/collectionseditor.py Outdated Show resolved Hide resolved
spyder/widgets/collectionseditor.py Outdated Show resolved Hide resolved
dpturibio and others added 4 commits April 22, 2024 21:40
Removal of extra parentheses

Co-authored-by: Carlos Cordoba <ccordoba12@gmail.com>
removal of extra parentheses

Co-authored-by: Carlos Cordoba <ccordoba12@gmail.com>
@dpturibio
Copy link
Contributor Author

Thanks for your contribution @dpturibio! I left two small suggestions for you, the rest looks good to me.

Thank you @ccordoba12 for the inputs on the small but well-pointed suggestions. If everything is ok for you, please proceed with the MR. Thank you again for all the support.

Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me now, thanks @dpturibio!

@ccordoba12 ccordoba12 merged commit 341000e into spyder-ide:master May 10, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhancement proposal: create a plot button in variable explorer to visualize numerical data
3 participants