-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR: Add ability to show plots for dataframes (Variable Explorer) #21969
Conversation
Hello @dpturibio! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2024-04-23 01:05:33 UTC |
Hey @dpturibio, thanks for your work on this! For now, please rebase on top of or merge with our latest master to get the fixes we did last week to our tests. |
Thank you @ccordoba12. |
@ccordoba12 let me know if code is ok to merge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution @dpturibio! I left two small suggestions for you, the rest looks good to me.
Removal of extra parentheses Co-authored-by: Carlos Cordoba <ccordoba12@gmail.com>
removal of extra parentheses Co-authored-by: Carlos Cordoba <ccordoba12@gmail.com>
Thank you @ccordoba12 for the inputs on the small but well-pointed suggestions. If everything is ok for you, please proceed with the MR. Thank you again for all the support. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me now, thanks @dpturibio!
Description of Changes
Enables "plot" item for dataframes following the same structure of code used for plotting arrays, that redirects the plot to IPython console at the end, using %varexp --plot [variable_name]
Issue(s) Resolved
Fixes #21743
Affirmation
By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.
I certify the above statement is true and correct: @dpturibio