PR: Remove icons from standard buttons in dialogs (UI/UX) #21945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @ccordoba12! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2024-04-06 02:14:53 UTC |
ccordoba12
force-pushed
the
improve-dialogs-ui
branch
from
91f4259
to
65a9f81
Compare
Also, increase vertical padding for buttons in dialogs to make them look better.
This widget is necessary to remove the default icons Qt adds to the standard buttons created in a regular QDialogButtonBox.
ccordoba12
force-pushed
the
improve-dialogs-ui
branch
from
65a9f81
to
33a0b0c
Compare
|
I discussed these changes with the UX team and they agree with them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Ok,Cancel,Reset, etc). However, that usually doesn't look good in Spyder because those icons come the operating system icon theme. So, in this PR I decided to remove them.3pxto4px) to make them look better.Visual changes
No icons for buttons in dialogs and increased vertical padding for them
Visual glitch in app menus
Affirmation
By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.
I certify the above statement is true and correct: