PR: Fix issues with scrolling in dataframe editor (Variable Explorer) #21913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jitseniesen
changed the title
Change DataFrameEditor so that it creates the DataFrameView in setup_ui() and the DataFrameModel in set_data_and_check(). This means that the DataFrameView is created only once, but the DataFrameModel is created every time the data is refreshed. Before, a new DataFrameView and a new DataFrameModel were created every time the data was refreshed. This fixes a bug where the scroll bars were not visible if the data frame too big. This commit also adds a test for this.
When setting the number of rows and columns loaded in the DataFrameHeaderModel, use the information in the corresponding DataFrameModel. This allows for the possibility that rows and columns were loaded before the DataFrameHeaderModel was created. This fixes a bug where a data frame editor with a large data frame was opened, so that not all columns are initially loaded. Then if you scroll to the last column and sort that column, a new DataFrameHeaderModel was created which used the wrong value of cols_loaded, causing the editor to scroll back. Also add a regression test for the bug.
jitseniesen
force-pushed
the
dataframe-scroll
branch
from
7ac6538
to
f497f40
Compare
ccordoba12
approved these changes
Mar 29, 2024
| df = DataFrame(numpy.zeros((100, 100))) | ||
| editor = DataFrameEditor() | ||
| editor.setup_and_check(df) | ||
| with qtbot.waitExposed(editor): |
There was a problem hiding this comment.
This is really nice! I didn't know about this functionality in qtbot.
ccordoba12
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
This PR fixes two scrolling-related bugs in the dataframe editor.
Firstly, after my PR implementing Refresh in the master branch, the scrollbars were no longer visible. To fix this, I changed it so that the view (the UI element) is created only once instead of every time that the data is refreshed. As before a new model (which exposes the data) is created every time that the data is refreshed.
Secondly, a bug already present in Spyder 5 caused the editor to jump back if you sorted the last column of a large data frame, as well as some more odd behaviour. The fix for this is to set the number of rows and columns loaded in the DataFrameHeaderModel using the information in the corresponding DataFrameModel. This is the bug reported in issue #21627.
This PR also add regression test for both these bugs.
Issue(s) Resolved
Fixes #21627
Affirmation
By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.
I certify the above statement is true and correct:
Jitse Niesen