Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Add icons for the remote connection dialog #21848

Merged

Conversation

conradolandia
Copy link
Contributor

@conradolandia conradolandia commented Mar 1, 2024

Description of Changes

  • Added new icons for the connection dialog > connection status tab, covering the following states:
    • Connecting
    • Connected
    • Disconnected
    • Error

SVG Icons

(The -dark and -light names don't exist on the source tree, the images reside in their respective folder, dark or light)

These icons will help illustrate the status of the connection in the remote connection dialog, inside the respective tab for the current remote connection.

Affirmation

By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct:
@conradolandia

Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The icons are really good, great work @conradolandia!

@ccordoba12 ccordoba12 changed the title Add icons for remote connection dialog PR: Add icons for the remote connection dialog Mar 5, 2024
@ccordoba12 ccordoba12 merged commit 3777e8d into spyder-ide:master Mar 5, 2024
@conradolandia conradolandia deleted the icons-connection-dialog branch March 14, 2024 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants