PR: Avoid conda run capturing output in env activation (IPython console)
#21788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- That restores capturing output from external processes and printing segfaults to the console. - Also, fix test_print_faulthandler because it started to fail due to env activation for the default env.
- That allows to show our kernel error message in every client connected to a conda environment that didn't start. - Also, update comment in test_kernel_crash accordingly.
ccordoba12
force-pushed
the
conda-run-no-capture
branch
2 times, most recently
from
476bfcb
to
98b4ed6
Compare
This fixes loading the project's session files or the ones in the previous session if a console was left in debugging mode.
This prevents freezes when closing Spyder and either a kernel restart or closing a client is requested while debugging.
ccordoba12
force-pushed
the
conda-run-no-capture
branch
2 times, most recently
from
13255db
to
93b8739
Compare
That's not really necessary because the plugin declares the same method, so it was being called twice when the main window is closed.
ccordoba12
force-pushed
the
conda-run-no-capture
branch
from
93b8739
to
86649d2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
pdb_prevent_closingoption when opening/closing projects. That's necessary to correctly restore the project or program session when a console is left in debugging mode (I discovered that bug while testing these changes).Affirmation
By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.
I certify the above statement is true and correct: @ccordoba12