Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Make some UI/UX improvements to the Find pane #21622

Merged
merged 6 commits into from
Dec 20, 2023

Conversation

ccordoba12
Copy link
Member

Description of Changes

  • In SearchInComboBox, disable clear list item and hide separator between regular items and other directories when users have not selected any other directory.
  • Remove tooltips from the SearchInComboBox items because they were annoying and unnecessary.
  • Change text of the action shown in the Search menu that points to the Find pane. That's to give users a better idea about it.
  • Fix bug when clicking on that action and (apparently) Spyder can't grab text for it.
  • Use an enum for the index items used in SearchInComboBox. This allows us to access them more easily.
  • Leave results browser visible after the first search is performed. This was very annoying because the empty message was shown when a new search was started or when no results were found.

Visual changes

Before

imagen

After

imagen

imagen

Issue(s) Resolved

Fixes #21538

Affirmation

By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct: @ccordoba12

This was generating a traceback when passing one of those paths to the
search thread.
This is useful to help users better understand how this action works.
That will allow us to reference them more easily.
This avoids showing the pane_empty widget when no results have been
found.
@pep8speaks
Copy link

Hello @ccordoba12! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 740:80: E501 line too long (80 > 79 characters)

@ccordoba12 ccordoba12 merged commit 3cf7dc5 into spyder-ide:master Dec 20, 2023
14 checks passed
@ccordoba12 ccordoba12 deleted the find-improvements branch December 20, 2023 03:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeError after clicking "Find in files" action
2 participants